Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Ballista executor so that FlightService delegates to an Executor struct #450

Merged
merged 5 commits into from
May 31, 2021

Conversation

andygrove
Copy link
Member

@andygrove andygrove commented May 30, 2021

Which issue does this PR close?

Closes #449 .

Rationale for this change

This is fixing some tech debt so that the executor doesn't have to connect to itself over Flight to run queries.

What changes are included in this PR?

Are there any user-facing changes?

No

@andygrove
Copy link
Member Author

@edrevo fyi

@codecov-commenter
Copy link

codecov-commenter commented May 30, 2021

Codecov Report

Merging #450 (7a969c1) into master (bdae93b) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #450   +/-   ##
=======================================
  Coverage   75.16%   75.17%           
=======================================
  Files         150      151    +1     
  Lines       25142    25140    -2     
=======================================
  Hits        18899    18899           
+ Misses       6243     6241    -2     
Impacted Files Coverage Δ
ballista/rust/executor/src/execution_loop.rs 0.00% <0.00%> (ø)
ballista/rust/executor/src/executor.rs 0.00% <0.00%> (ø)
ballista/rust/executor/src/flight_service.rs 0.00% <0.00%> (ø)
ballista/rust/executor/src/main.rs 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdae93b...7a969c1. Read the comment docs.

@alamb alamb merged commit c8ab5a4 into apache:master May 31, 2021
@andygrove andygrove deleted the refactor-ballista-flight branch May 31, 2021 15:05
@houqp houqp added ballista enhancement New feature or request labels Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Ballista to separate Flight logic from execution logic
6 participants