Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified usage of use arrow in ballista. #447

Merged
merged 1 commit into from
May 30, 2021

Conversation

jorgecarleitao
Copy link
Member

Closes #446

Also simplifies many of the internal imports, removing unused imports and place them all at the top of the module / file.

@codecov-commenter
Copy link

Codecov Report

Merging #447 (6861cf8) into master (321fda4) will increase coverage by 0.00%.
The diff coverage is 62.31%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #447   +/-   ##
=======================================
  Coverage   75.16%   75.16%           
=======================================
  Files         150      150           
  Lines       25144    25142    -2     
=======================================
  Hits        18899    18899           
+ Misses       6245     6243    -2     
Impacted Files Coverage Δ
ballista/rust/client/src/columnar_batch.rs 0.00% <ø> (ø)
ballista/rust/client/src/context.rs 0.00% <ø> (ø)
ballista/rust/core/src/client.rs 0.00% <ø> (ø)
ballista/rust/core/src/datasource.rs 0.00% <ø> (ø)
ballista/rust/core/src/error.rs 0.00% <ø> (ø)
...lista/rust/core/src/execution_plans/query_stage.rs 42.85% <ø> (ø)
...ta/rust/core/src/execution_plans/shuffle_reader.rs 0.00% <ø> (ø)
...ust/core/src/execution_plans/unresolved_shuffle.rs 50.00% <ø> (ø)
ballista/rust/core/src/memory_stream.rs 0.00% <ø> (ø)
...ta/rust/core/src/serde/physical_plan/from_proto.rs 39.78% <ø> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 321fda4...6861cf8. Read the comment docs.

@andygrove andygrove merged commit bdae93b into apache:master May 30, 2021
@jorgecarleitao jorgecarleitao deleted the improve_uses branch May 30, 2021 18:52
@houqp houqp added the ballista label Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Ballista not depend on arrow directly
4 participants