Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option param for standalone mode #42

Merged
merged 2 commits into from
Apr 27, 2021

Conversation

kination
Copy link
Contributor

@kination kination commented Apr 24, 2021

Related Issue

#43

Rationale for this change

Currently StandaloneClient instance can be created by saving data to a specific file, or to temporary file. But it executor only runs by generating temporary file, so add parameter to give specific file path.

What changes are included in this PR?

It creates client with StandaloneClient::try_new(path) if path has been defined, or StandaloneClient::try_new_temporary() if not defined.

@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2021

Codecov Report

Merging #42 (842c775) into master (32951c3) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
- Coverage   76.24%   76.24%   -0.01%     
==========================================
  Files         134      134              
  Lines       23023    23053      +30     
==========================================
+ Hits        17554    17576      +22     
- Misses       5469     5477       +8     
Impacted Files Coverage Δ
ballista/rust/executor/src/main.rs 0.00% <0.00%> (ø)
datafusion/src/physical_plan/group_scalar.rs 55.29% <0.00%> (-2.03%) ⬇️
datafusion/src/physical_plan/hash_join.rs 86.42% <0.00%> (-0.18%) ⬇️
datafusion/src/physical_plan/hash_aggregate.rs 85.90% <0.00%> (-0.17%) ⬇️
datafusion/src/scalar.rs 54.03% <0.00%> (ø)
datafusion/src/execution/context.rs 92.94% <0.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32951c3...842c775. Read the comment docs.

@andygrove
Copy link
Member

Hi @djKooks thanks for the PR. Because you were a contributor to the Ballista code that was donated, I believe that we need you to file a contributor license agreement with the ASF before accepting further contributions. I tried reaching you during the donation process but wasn't able to.

Instructions are here. Let me know if you need any help.

https://www.apache.org/licenses/contributor-agreements.html

Thanks!

@kination
Copy link
Contributor Author

@andygrove thanks for review.
I've just found that my request has been refused because of some missing information. I just updated and resend it.

Please review after it has been approved 🙏

@alamb alamb requested a review from andygrove April 26, 2021 21:20
@andygrove andygrove merged commit e86ad26 into apache:master Apr 27, 2021
@kination kination deleted the update/standalone-with-path branch April 27, 2021 05:39
@houqp houqp added the enhancement New feature or request label Jul 29, 2021
alamb pushed a commit that referenced this pull request Oct 17, 2024
…regation (#12946)

* Improve unparsing for ORDER BY with Aggregation functions (#38)

* Improve UNION unparsing (#39)

* Scalar functions in ORDER BY unparsing support (#41)

* Improve unparsing for complex Window functions with Aggregation (#42)

* WindowFunction order_by should respect `supports_nulls_first_in_sort` dialect setting (#43)

* Fix plan_to_sql

* Improve
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants