Benchmark subcommand to distinguish between DataFusion and Ballista #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #402 +/- ##
=======================================
Coverage 74.94% 74.94%
=======================================
Files 146 146
Lines 24314 24314
=======================================
+ Hits 18221 18223 +2
+ Misses 6093 6091 -2
Continue to review full report at Codecov.
|
andygrove
reviewed
May 24, 2021
|
There are two other files which will need updating:
|
Fixed DataFusionBenchmarkOpts name and raspberrypi.md in last commit. |
andygrove
approved these changes
May 24, 2021
jimexist
pushed a commit
to jimexist/arrow-datafusion
that referenced
this pull request
May 26, 2021
…pache#402) * apache#401: Add subcommand to TPC-H benchmark args to distinguish between DataFusion and Ballista * fix benchmark subcommand name * Fix lint * fix benchmark tests using DatafusionBenchmarkOpts * Fix DataFusionBenchmarkOpts name and update doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #401.
Rationale for this change
What changes are included in this PR?
It defines a BenchmarkSubCommandOpt to allow different arguments depending on whether it is run against ballista or datafusion.
Are there any user-facing changes?
It changes tpch bin arugments generated by benchmarks project.
It contains changes in benchmarks/README.md and benchmars/run.sh files.