Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement fmt_as for ShuffleReaderExec #400

Merged
merged 3 commits into from
May 24, 2021

Conversation

andygrove
Copy link
Member

@andygrove andygrove commented May 23, 2021

Which issue does this PR close?

Before:

SortExec: [revenue DESC]
  ProjectionExec: expr=[n_name, SUM(l_extendedprice Multiply Int64(1) Minus l_discount) as revenue]
    HashAggregateExec: mode=Final, gby=[n_name], aggr=[SUM(l_extendedprice Multiply Int64(1) Minus l_discount)]
      ExecutionPlan(PlaceHolder)

After:

SortExec: [revenue DESC]
  ProjectionExec: expr=[n_name, SUM(l_extendedprice Multiply Int64(1) Minus l_discount) as revenue]
    HashAggregateExec: mode=Final, gby=[n_name], aggr=[SUM(l_extendedprice Multiply Int64(1) Minus l_discount)]
      ShuffleReaderExec: partition_locations=[executor=cb5f9a3b-69ed-4261-b3b5-38ba74ba7e30 part=50ELpmq:1:0 stats=PartitionStats { num_rows: None, num_batches: None, num_bytes: None }]

Closes #399.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2021

Codecov Report

Merging #400 (030d342) into master (174226c) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #400      +/-   ##
==========================================
- Coverage   74.94%   74.90%   -0.05%     
==========================================
  Files         146      146              
  Lines       24314    24328      +14     
==========================================
  Hits        18223    18223              
- Misses       6091     6105      +14     
Impacted Files Coverage Δ
...ta/rust/core/src/execution_plans/shuffle_reader.rs 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 174226c...030d342. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit 0aea0df into apache:master May 24, 2021
@houqp houqp added ballista enhancement New feature or request labels Jul 29, 2021
@andygrove andygrove deleted the shuffle-reader-fmt-as branch February 6, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ShuffleReaderExec does not get formatted correctly in displayable physical plan
5 participants