-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use prettier to format md files #367
Conversation
Codecov Report
@@ Coverage Diff @@
## master #367 +/- ##
=======================================
Coverage 75.88% 75.88%
=======================================
Files 143 143
Lines 23773 23773
=======================================
Hits 18041 18041
Misses 5732 5732 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good 👍 @jimexist should we also add a .prettierrc file if we used custom settings & lint task during build? Maybe a separate PR at a later time is fine as well.
1bbc8e3
to
103c87c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed the rendered changes manually by looking at
https://github.com/Jimexist/arrow-datafusion/tree/update-docs-format
And they look good -- thanks @jimexist
-V, --version Prints version information | ||
|
||
OPTIONS: | ||
-c, --batch-size <batch-size> The batch size of each query, default value is 1048576 | ||
-c, --batch-size <batch-size> The batch size of each query, or use DataFusion default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thanks I've been thinking of adding a non failing CI job so that future changes can be detected |
The philosophy of prettier is to apply as little config as possible so if not necessary I can leave out the rc file |
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?