cleanup function return type fn #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #350 +/- ##
==========================================
+ Coverage 75.72% 75.84% +0.11%
==========================================
Files 143 143
Lines 23910 23809 -101
==========================================
- Hits 18107 18059 -48
+ Misses 5803 5750 -53
Continue to review full report at Codecov.
|
jimexist
force-pushed
the
cleanup-return-type
branch
from
a9fae88
to
bf9290f
Compare
|
This PR appears to need a rebase |
jimexist
force-pushed
the
cleanup-return-type
branch
from
bf9290f
to
28f44a5
Compare
|
So ✨ clean 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
function return type fn is too clumsy and we can use macros to clean it up.
Are there any user-facing changes?
this is purely code refactoring, no user facing changes.