Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ballista to use new physical plan formatter utility #344

Merged
merged 2 commits into from
May 19, 2021

Conversation

andygrove
Copy link
Member

Which issue does this PR close?

Closes #343.

Rationale for this change

See Closes #343.

What changes are included in this PR?

Remove Ballista's format_plan utility and change call sites to use displayable instead.

Are there any user-facing changes?

No, this is all internal debug logging.

@codecov-commenter
Copy link

Codecov Report

Merging #344 (727114d) into master (1702d6c) will increase coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #344      +/-   ##
==========================================
+ Coverage   75.72%   75.73%   +0.01%     
==========================================
  Files         143      143              
  Lines       23832    23776      -56     
==========================================
- Hits        18046    18007      -39     
+ Misses       5786     5769      -17     
Impacted Files Coverage Δ
ballista/rust/core/src/utils.rs 0.00% <ø> (-30.44%) ⬇️
ballista/rust/executor/src/flight_service.rs 0.00% <0.00%> (ø)
ballista/rust/scheduler/src/planner.rs 69.46% <100.00%> (ø)
...lista/rust/core/src/execution_plans/query_stage.rs 42.85% <0.00%> (-4.77%) ⬇️
datafusion/src/logical_plan/operators.rs 77.14% <0.00%> (-2.86%) ⬇️
datafusion/src/physical_plan/expressions/sum.rs 78.20% <0.00%> (+1.28%) ⬆️
datafusion/src/physical_plan/mod.rs 87.05% <0.00%> (+2.35%) ⬆️
datafusion/src/physical_plan/expressions/mod.rs 71.42% <0.00%> (+3.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1702d6c...727114d. Read the comment docs.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like an improvement to me :)

@andygrove andygrove force-pushed the remove-ballista-format-plan branch from 727114d to cb4103c Compare May 19, 2021 14:37
@andygrove andygrove merged commit 371c240 into apache:master May 19, 2021
@andygrove andygrove deleted the remove-ballista-format-plan branch May 19, 2021 15:52
@houqp houqp added the ballista label Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Ballista to use new physical plan formatter utility
4 participants