Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to Ballista Docker images published to ballistacompute Docker Hub repo #326

Merged
merged 1 commit into from
May 12, 2021

Conversation

andygrove
Copy link
Member

@andygrove andygrove commented May 12, 2021

Which issue does this PR close?

Builds on #322 and closes #325.

Rationale for this change

It should be possible to build Ballista from this repo without depending on any previously published Ballista Docker base images.

What changes are included in this PR?

Remove references to ballistacompute images.

Are there any user-facing changes?

No

@andygrove andygrove changed the title Ballista packaging Remove references to Ballista Docker images published to ballistacompute Docker Hub repo May 12, 2021
@andygrove
Copy link
Member Author

@edrevo fyi

@codecov-commenter
Copy link

Codecov Report

Merging #326 (ed56d64) into master (a1c6898) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     apache/arrow-datafusion#326   +/-   ##
=======================================
  Coverage   76.19%   76.19%           
=======================================
  Files         141      141           
  Lines       23786    23786           
=======================================
  Hits        18123    18123           
  Misses       5663     5663           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1c6898...ed56d64. Read the comment docs.

Copy link
Member

@jorgecarleitao jorgecarleitao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @andygrove !

Copy link
Contributor

@edrevo edrevo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean there aren't going to be any official ballista docker images?

@andygrove
Copy link
Member Author

Does this mean there aren't going to be any official ballista docker images?

No, I'd like to publish official Docker images in addition to letting users build and publish their own images. See apache/datafusion-ballista#455

@alamb alamb merged commit 69e64c4 into apache:master May 12, 2021
@andygrove andygrove deleted the ballista-packaging branch February 6, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove references to ballistacompute Docker Hub repo
5 participants