Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Fix integration tests by adding datafusion-cli module to docker image #322

Merged
merged 1 commit into from
May 12, 2021

Conversation

andygrove
Copy link
Member

The recent changes to move DataFusion CLI to a separate crate broke the Ballista integration tests. This PR simply adds this crate to the Docker image used by the integration tests.

For anyone that is interested, integration tests can be run with this command:

./dev/integration-tests.sh

I filed apache/datafusion-ballista#24 for adding these tests to CI

@codecov-commenter
Copy link

Codecov Report

Merging #322 (ca42d33) into master (a1c6898) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     apache/arrow-datafusion#322   +/-   ##
=======================================
  Coverage   76.19%   76.19%           
=======================================
  Files         141      141           
  Lines       23786    23786           
=======================================
  Hits        18123    18123           
  Misses       5663     5663           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1c6898...ca42d33. Read the comment docs.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I didn't test it but 👍

@alamb alamb merged commit 3f269b9 into apache:master May 12, 2021
@andygrove andygrove deleted the fix-it branch February 6, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants