Make ExecutionPlan::execute Sync
#2434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I plan to review this PR carefully today |
|
Oops meant to mark this as draft, #2428 needs to go in first |
|
@tustvold This PR didn't take as long to review as I thought. It is really just the Ballista changes that were large and I will rely on the integration tests to confirm that everything is working as expected, so LGTM so far but needs rebasing/upmerging now before I can complete my review. |
tustvold
force-pushed
the
sync-execution-plan
branch
from
d2d5397
to
d89be58
Compare
tustvold
force-pushed
the
sync-execution-plan
branch
from
d89be58
to
2ae8cd8
Compare
|
Rebased, this PR is pretty mechanical, as prior PRs laid the necessary groundwork for it |
tustvold
commented
May 4, 2022
| @@ -125,23 +122,8 @@ impl ExecutionPipeline { | |||
| // Construct the output streams | |||
| let output_count = proxied.output_partitioning().partition_count(); | |||
| let outputs = (0..output_count) | |||
| .map(|x| { | |||
|
I agree this is a good change -- thanks @tustvold and @andygrove 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2307
Rationale for this change
See ticket but the major benefits are:
ExecutionPlan::Execute, i.e. during planWhat changes are included in this PR?
Makes
ExecutionPlan::executeand by extensionExecutionPlanitself, syncAre there any user-facing changes?
Yes, this is a breaking change to a fundamental trait.