Re-organize and rename aggregates physical plan #2388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjshen
commented
Apr 30, 2022
| }; | ||
|
|
||
| /// stream struct for aggregation without grouping columns | ||
| pub(crate) struct NoGroupingAggregateStream { |
There was a problem hiding this comment.
Any suggestions on the name of this single-state aggregation?
andygrove
reviewed
May 1, 2022
ballista/rust/core/src/utils.rs
Outdated
| @@ -151,7 +151,7 @@ fn build_exec_plan_diagram( | |||
| id: &mut AtomicUsize, | |||
| draw_entity: bool, | |||
| ) -> Result<usize> { | |||
| let operator_str = if plan.as_any().downcast_ref::<HashAggregateExec>().is_some() { | |||
| let operator_str = if plan.as_any().downcast_ref::<AggregateExec>().is_some() { | |||
| "HashAggregateExec" | |||
There was a problem hiding this comment.
Should we also change the operator string here to remove Hash ?
There was a problem hiding this comment.
Thanks @andygrove. I've updated all these explanation strings and checked all occurrences of hash_aggregate and HashAggregate.
alamb
approved these changes
May 1, 2022
| @@ -306,19 +306,21 @@ impl AsExecutionPlan for PhysicalPlanNode { | |||
| Arc::new((&input_schema).try_into()?), | |||
| )?)) | |||
| } | |||
| PhysicalPlanType::HashAggregate(hash_agg) => { | |||
| PhysicalPlanType::Aggregate(hash_agg) => { | |||
| }; | ||
|
|
||
| /// stream struct for aggregation without grouping columns | ||
| pub(crate) struct NoGroupingAggregateStream { |
andygrove
approved these changes
May 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2387.
Rationale for this change
GroupedHashAggregateStreamfor aggregate with grouping keys, and a non-hash implementation for aggregate without grouping keys but namedHashAggregateStream.What changes are included in this PR?
Are there any user-facing changes?
No.
No.