Add BatchPartitioner (#2285) #2287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dandandan
approved these changes
Apr 20, 2022
Dandandan
reviewed
Apr 20, 2022
| @@ -87,7 +87,7 @@ impl BatchPartitioner { | |||
| /// Create a new [`BatchPartitioner`] with the provided [`Partitioning`] | |||
| /// | |||
| /// The time spent repartitioning will be recorded to `timer` | |||
| pub fn new(partitioning: Partitioning, timer: metrics::Time) -> Self { | |||
| pub fn new(partitioning: Partitioning, timer: metrics::Time) -> Result<Self> { | |||
There was a problem hiding this comment.
Shouldn´t this be try_new now by convention?
|
Thanks @tustvold 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2285
Rationale for this change
Extracts common logic so it can be used by RepartitionExec, Ballista and #2226
What changes are included in this PR?
Adds a [
BatchPartitioner] that contains the logic for partitioning batchesAre there any user-facing changes?
No