Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Arrow 12.0.0, update tonic and prost #2253

Merged
merged 6 commits into from
Apr 19, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Apr 17, 2022

This updates datafusion / ballista to use arrow 12.0.0, including upgrades to tonic / prost dependencies

Draft until arrow 12 is officially released

Also closes #2160 as it updates etcd client

@github-actions github-actions bot added ballista datafusion Changes in the datafusion crate labels Apr 17, 2022
@@ -0,0 +1,39 @@
# Licensed to the Apache Software Foundation (ASF) under one
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was copied from arrow-rs , from apache/arrow-rs#1510

@xudong963
Copy link
Member

xudong963 commented Apr 17, 2022

By the way how about upgrading etcd-client #2160 in the ticket😂.
I tested it locally and changed it directly to 0.9 compiling and testing with no problems.

@alamb
Copy link
Contributor Author

alamb commented Apr 17, 2022

By the way how about upgrading etcd-client #2160 in the thick😂.

Good idea -- will add

@alamb alamb force-pushed the alamb/prepare_arrow_12 branch from 4747c63 to ffd84bb Compare April 19, 2022 13:26
Copy link
Member

@xudong963 xudong963 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alamb alamb marked this pull request as ready for review April 19, 2022 15:23
@alamb
Copy link
Contributor Author

alamb commented Apr 19, 2022

Thanks @xudong963 !

Copy link
Member

@yjshen yjshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this. Thanks @alamb!

@alamb alamb merged commit 7548e96 into apache:master Apr 19, 2022
@alamb alamb deleted the alamb/prepare_arrow_12 branch April 19, 2022 17:09
@alamb
Copy link
Contributor Author

alamb commented Apr 19, 2022

Thanks @yjshen

mcheshkov added a commit to cube-js/arrow-datafusion that referenced this pull request Aug 22, 2024
Can drop this after rebase on commit 7548e96 "Update to Arrow 12.0.0, update tonic and prost (apache#2253)", first released in 8.0.0
mcheshkov added a commit to cube-js/arrow-datafusion that referenced this pull request Aug 22, 2024
Can drop this after rebase on commit 7548e96 "Update to Arrow 12.0.0, update tonic and prost (apache#2253)", first released in 8.0.0
mcheshkov added a commit to cube-js/arrow-datafusion that referenced this pull request Aug 30, 2024
Can drop this after rebase on commit 7548e96 "Update to Arrow 12.0.0, update tonic and prost (apache#2253)", first released in 8.0.0
mcheshkov added a commit to cube-js/arrow-datafusion that referenced this pull request Aug 30, 2024
Can drop this after rebase on commit 7548e96 "Update to Arrow 12.0.0, update tonic and prost (apache#2253)", first released in 8.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datafusion Changes in the datafusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants