Add ExecutorMetricsCollector interface #2234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
approved these changes
Apr 15, 2022
There was a problem hiding this comment.
This looks like a good improvement to me. Thanks @thinkharderdev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2204
Rationale for this change
Currently there is no way of getting execution metrics from Ballista executors (aside from parsing log messages). This adds a trait
ExecutorMetricsCollectorwhich can record stage execution metrics. Currently it just defaults toLoggingMetricsCollectorwhich just logs the plan (same as before).I'm also working on a prometheus metrics collector which we can upstream (under a feature flag) when it's ready.
What changes are included in this PR?
ExecutorMetricsCollectortraitLoggingMetricsCollectorimplementationExecutorneeds to own anArc<dyn ExecutorMetricsCollector>and callrecord_stageafter executing a shuffle write.Are there any user-facing changes?
No
No