Add IF NOT EXISTS to CREATE TABLE and CREATE EXTERNAL TABLE
#2143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i think i will add this option to |
matthewmturner
changed the title
CREATE TABLE and CREATE EXTERNAL TABLE
alamb
reviewed
Apr 4, 2022
There was a problem hiding this comment.
The code looks good to me -- thank you @matthewmturner
I think it would be worth one sql test -- perhaps inhttps://github.com/WinkerDu/arrow-datafusion/blob/master-string-concat/datafusion/core/tests/sql/create_drop.rs#L25 to show that this code was all hooked up correctly (and ensure we didn't break the connections accidentally)
|
@alamb sure will add one. |
|
@alamb I believe this is ready. |
alamb
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Task 14 of #1777
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?