Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ballista] Support Union in ballista. #2098

Merged
merged 7 commits into from
Mar 27, 2022
Merged

Conversation

Ted-Jiang
Copy link
Member

@Ted-Jiang Ted-Jiang commented Mar 26, 2022

Which issue does this PR close?

Closes #2032 .

Rationale for this change

Use cargo run --bin datafusion-cli --features ballista -- --host localhost --port 50050
Before

 SELECT 1 as NUMBER union SELECT 1 as NUMBER;
thread 'main' panicked at 'not implemented', ballista/rust/core/src/serde/logical_plan/mod.rs:818:38
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Now

❯ SELECT 1 as NUMBER union SELECT 1 as NUMBER;
+--------+
| number |
+--------+
| 1      |
+--------+
1 row in set. Query took 1.085 seconds.
❯ SELECT 1 as NUMBER union all SELECT 1 as NUMBER;
+--------+
| number |
+--------+
| 1      |
| 1      |
+--------+
2 rows in set. Query took 0.225 seconds.

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added ballista datafusion Changes in the datafusion crate labels Mar 26, 2022
@houqp houqp added the enhancement New feature or request label Mar 27, 2022
Copy link
Member

@houqp houqp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alamb alamb merged commit 73ea6e1 into apache:master Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datafusion Changes in the datafusion crate enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnionAll support for Ballista
3 participants