Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change log level for noisy logs #2060

Merged
merged 1 commit into from
Mar 23, 2022
Merged

Conversation

thinkharderdev
Copy link
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

These two logs statements were creating a lot of noise. They can be valuable for debugging but think they should be debug logs instead of info logs.

What changes are included in this PR?

Are there any user-facing changes?

Copy link
Member

@Ted-Jiang Ted-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yjshen yjshen merged commit 29d0a65 into apache:master Mar 23, 2022
@thinkharderdev thinkharderdev deleted the scheduler-log-level branch March 23, 2022 10:42
@mingmwang
Copy link
Contributor

mingmwang commented Mar 25, 2022

Hi, @Ted-Jiang @yahoNanJing

I think in the pull based task assignment model, if the system is idle, maybe we should let the executor slow down the polling interval. Otherwise there will be too many RPCs between Scheduler and Executor if there are many Executor nodes in the system even when the system is idle.

@Ted-Jiang
Copy link
Member

Ted-Jiang commented Mar 26, 2022

Hi, @Ted-Jiang @yahoNanJing

I think in the pull based task assignment model, if the system is idle, maybe we should let the executor slow down the polling interval. Otherwise there will be too many RPCs between Scheduler and Executor if there are many Executor nodes in the system even when the system is idle.

Thanks @mingmwang its a good idea. Now we hard code it in 1 mins:
https://github.com/apache/arrow-datafusion/blob/8de2a7610df33adf75ba515c4ee2fe935f7aa114/ballista/rust/executor/src/executor_server.rs#L263
How to test the best interval is a problem. @mingmwang ans suggestions 😊?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants