Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify prerequisites for running examples #2028

Merged
merged 4 commits into from
Mar 18, 2022
Merged

Simplify prerequisites for running examples #2028

merged 4 commits into from
Mar 18, 2022

Conversation

doki23
Copy link
Contributor

@doki23 doki23 commented Mar 17, 2022

Which issue does this PR close?

Closes #2014

@github-actions github-actions bot added ballista datafusion Changes in the datafusion crate labels Mar 17, 2022
Copy link
Member

@yjshen yjshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@@ -47,9 +47,6 @@ RUST_LOG=info ./target/release/ballista-executor -c 4

## Running the examples

Refer to the instructions in [DEVELOPERS.md](../DEVELOPERS.md) to define the `ARROW_TEST_DATA` and
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, I found https://github.com/apache/arrow-datafusion/blob/master/DEVELOPERS.md doesn't exist 😂, maybe it refers to CONTRIBUTING.md

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@xudong963 xudong963 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @doki23

@xudong963 xudong963 merged commit 485bfa6 into apache:master Mar 18, 2022
@doki23 doki23 deleted the simplify_example branch March 24, 2023 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datafusion Changes in the datafusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot run examples of ballista
3 participants