-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Dockerfile to fix integration tests #1982
Conversation
Thanks for fixing the tests 👍 |
x-post from another PR: I checked the pipeline definition the integration test is not part of it. I think at some point we should include it. @andygrove @alamb should we do that now? I guess one concern might be if we want it to block the whole DataFusion pipeline if this fails |
It seems I was unable to run the integration tests using this PR locally due to an arrow compilation error: run:
Finally get:
|
@realno We have an issue open for adding these tests to CI [1]. I remember there was an effort to implement this some time ago but there were some technical challenges, IIRC. It would be great if someone could have another go at this. |
@yjshen Could you file a follow-on issue if you are still not able to compile, with some more detail about the error. |
Which issue does this PR close?
Closes #1979
Rationale for this change
Fix integration tests
What changes are included in this PR?
Update Dockerfile to use new crates
Are there any user-facing changes?
No