fix a typo #1919
Merged
fix a typo #1919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I64d2169a616efb889b3e37e85450405729eed499
|
I noticed https://github.com/apache/arrow-datafusion/blob/bc42eadd5b03cc4e1c541f4e37ab5f54fa3db714/datafusion-common/src/dfschema.rs#L287 has the same typo, could you please fix it together? |
alamb
approved these changes
Mar 5, 2022
There was a problem hiding this comment.
Thanks @vchag -- please let me know if you want to fix @xudong963 's suggestion in this PR or if I should merge this one as is
Thanks for pointing it out. I'll fix it. |
you're welcome @alamb. I fixed the typo in the other file. You can merge both of these changes. |
xudong963
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I64d2169a616efb889b3e37e85450405729eed499
Which issue does this PR close?
This PR is related to correcting a typo and not related to functionality issues.
Closes #.
Rationale for this change
I made this change to ensure users don't get confused. Comments help new users like me understand the code.