Refactor scheduler server #1911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkharderdev
approved these changes
Mar 4, 2022
| } | ||
| let mut num_tasks = 0; | ||
| loop { | ||
| info!("Go inside fetching task loop"); |
There was a problem hiding this comment.
realize you didn't add this here, but can we change this to debug level? could add a lot of noise to the logs
|
Rather than allow PRs to accumulate, I'll merge them in as they seem uncontroversial and have been reviewed. We can always continue reorganizing as we move forward. Thanks @yahoNanJing for the code and @thinkharderdev for the review |
|
I go through this pull request, and it's just split the code into some separated files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1908.
Rationale for this change
Reorganize the scheduler contents for better code review and easy feature additions.
What changes are included in this PR?
The following separate mod are extracted from the scheduler contents:
Are there any user-facing changes?