Updated Rust version to 1.59 in all the files #1903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
@alamb Please trigger the workflows. Thank you! |
|
nit: Please add |
added |
|
After I update the rust version to 1.59 in my local, running |
This is a little weird. I test on my desktop, and everything works fine. (base) remziy@remzi-desktop:~/Datafusion$ git checkout pr_1903
Switched to branch 'pr_1903'
(base) remziy@remzi-desktop:~/Datafusion$ rustup -V
rustup 1.24.3 (ce5817a94 2021-05-31)
info: This is the version for the rustup toolchain manager, not the rustc compiler.
info: The currently active `rustc` version is `rustc 1.59.0 (9d1b2106e 2022-02-23)`
(base) remziy@remzi-desktop:~/Datafusion$ cargo -V
cargo 1.59.0 (49d8809dc 2022-02-10)
(base) remziy@remzi-desktop:~/Datafusion$ rustc -V
rustc 1.59.0 (9d1b2106e 2022-02-23)
(base) remziy@remzi-desktop:~/Datafusion$ cargo clippy
Checking datafusion v7.0.0 (/home/Datafusion/datafusion)
Checking ballista-core v0.6.0 (/home/Datafusion/ballista/rust/core)
Checking datafusion-cli v7.0.0 (/home/Datafusion/datafusion-cli)
Checking ballista v0.6.0 (/home/Datafusion/ballista/rust/client)
Checking ballista-executor v0.6.0 (/home/Datafusion/ballista/rust/executor)
Checking ballista-scheduler v0.6.0 (/home/Datafusion/ballista/rust/scheduler)
Checking arrow-benchmarks v5.0.0 (/home/Datafusion/benchmarks)
Checking ballista-examples v0.6.0 (/home/Datafusion/ballista-examples)
Finished dev [unoptimized + debuginfo] target(s) in 9.78s |
Possibly this is related rust-lang/rust-clippy#8470 |
alamb
approved these changes
Mar 2, 2022
|
Thank you @alamb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @HaoYang670 I have updated rust version in all the files. Please review this and if any changes needed do inform me.
Thanks!
#1902
closes #1902