Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiling ballista in standalone mode, add build to CI #1839

Merged
merged 5 commits into from
Feb 16, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Feb 15, 2022

Which issue does this PR close?

TBD

Rationale for this change

As pointed by @thinkharderdev on #1810 #1810 (comment) compiling with ballista is currently broken (likely by #1677 and #1715):

(arrow_dev) alamb@MacBook-Pro-2:~/Software/arrow-datafusion/ballista/rust$ cargo test --no-default-features --features standalone
   Compiling etcd-client v0.8.3
   Compiling ballista-scheduler v0.6.0 (/Users/alamb/Software/arrow-datafusion/ballista/rust/scheduler)
   Compiling ballista v0.6.0 (/Users/alamb/Software/arrow-datafusion/ballista/rust/client)
error[E0061]: this function takes 3 arguments but 2 arguments were supplied
  --> ballista/rust/client/src/context.rs:93:9
   |
93 |         ballista_executor::new_standalone_executor(scheduler, concurrent_tasks).await?;
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ---------  ---------------- supplied 2 arguments
   |         |
   |         expected 3 arguments
   |
note: function defined here
  --> /Users/alamb/Software/arrow-datafusion/ballista/rust/executor/src/standalone.rs:38:14
   |
38 | pub async fn new_standalone_executor<
   |              ^^^^^^^^^^^^^^^^^^^^^^^

For more information about this error, try `rustc --explain E0061`.
error: could not compile `ballista` due to previous error
warning: build failed, waiting for other jobs to finish...
error: build failed

What changes are included in this PR?

  1. Fix compile
  2. Add cargo test --features=standalone for ballista to CI
  3. Disabled test_task_stuck_when_referenced_task_failed test due to Ballista standalone mode tests fail: context::tests::test_task_stuck_when_referenced_task_failed datafusion-ballista#25

Are there any user-facing changes?

No

@@ -458,13 +469,16 @@ mod tests {

#[tokio::test]
#[cfg(feature = "standalone")]
#[ignore]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, that's where I got stuck as well :). I can take a look at the failing test and fix it another PR. Thanks!

@alamb alamb merged commit 0a1eee0 into apache:master Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants