Improve the error message and UX of tpch benchmark program #1800
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1799
Rationale for this change
When I run the command as suggested in
https://github.com/apache/arrow-datafusion/blob/alamb%2Fbetter_bench_ux/benchmarks/README.md#L1
It errors like this which does not tell me what file it is searching for so I don't know how to fix the problem
the issue is I am running from the
arrow-datafusion
directory but the program is looking for a file likequeries/1.sql
and the actual location isdatafusion/benchmarks/queries/1
What changes are included in this PR?
This PR adds additional searching paths for the files and produces a nicer error if they aren't found
Example Error:
Are there any user-facing changes?
fewer errors and better error messages