Update to sqlparser 0.14 #1796
Merged
Update to sqlparser 0.14 #1796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ballista
datafusion
alamb
commented
Feb 9, 2022
| FunctionArg::Unnamed(arg) => arg, | ||
| }; | ||
|
|
||
| match arg { |
There was a problem hiding this comment.
Needed due to apache/datafusion-sqlparser-rs#378 from @panarch (so we don't allow crazy stuff like SELECT * + * from foo 👍
alamb
commented
Feb 9, 2022
| expr: Box::new(expr), | ||
| key: plan_key(key), | ||
| } | ||
| fn plan_indexed(expr: Expr, mut keys: Vec<SQLExpr>) -> Result<Expr> { |
There was a problem hiding this comment.
I had to change this code anyways to handle arbitrary expressions due to apache/datafusion-sqlparser-rs#382 so I took the time to remove the clippy warning too
alamb
force-pushed
the
alamb/test_update_sqlparser
branch
from
209b70e to
dc360f5
Compare
|
I think it might be nice to update to latest sqlparser before the 7.0.0 release |
xudong963
approved these changes
Feb 11, 2022
|
Thanks @xudong963 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft until sqlparser 0.14 is actually releasedWhich issue does this PR close?
Closes #1804
Rationale for this change
A new version of sqlparser is about to be released, and this PR serves as potential QA for this effort
What changes are included in this PR?
Are there any user-facing changes?
New dependency and some new SQL syntax support