Add support show tables and show columns for ballista #1593
Conversation
| @@ -256,6 +288,14 @@ impl BallistaContext { | |||
| ) | |||
| }; | |||
|
|
|||
| let is_show = self.is_show_statement(sql).await?; | |||
There was a problem hiding this comment.
I wonder if there is some reason not to always use the with_information_schema?
There was a problem hiding this comment.
Is it ok set information_schema: true, by default ? if not may i ask which situation need block this for user 😊
https://github.com/apache/arrow-datafusion/blob/82e80036d9dbcf1bacac8e94eb10d5c60a8016a7/datafusion/src/execution/context.rs#L930
There was a problem hiding this comment.
Datafusion supports show tables only when with_information_schema=true. Currently, users cannot specify the with_information_schema parameter of datafusion when creating a ballista context. I can add a with_information_schema parameter in BallistaConfig, the default value is false, when users need to use show tables in ballista, users can turn on this function through with_information_schema(true).
| @@ -256,6 +288,14 @@ impl BallistaContext { | |||
| ) | |||
| }; | |||
|
|
|||
| let is_show = self.is_show_statement(sql).await?; | |||
There was a problem hiding this comment.
Is it ok set information_schema: true, by default ? if not may i ask which situation need block this for user 😊
https://github.com/apache/arrow-datafusion/blob/82e80036d9dbcf1bacac8e94eb10d5c60a8016a7/datafusion/src/execution/context.rs#L930
Which issue does this PR close?
Closes #1592.