Update to rust 1.58 #1557
Merged
Update to rust 1.58 #1557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's use the latest Rust version and learn what has changed! |
xudong963
commented
Jan 14, 2022
| @@ -293,7 +293,7 @@ mod test { | |||
| .plan_query_stages(&job_uuid.to_string(), plan) | |||
| .await?; | |||
| for stage in &stages { | |||
| println!("{}", displayable(stage.as_ref()).indent().to_string()); | |||
| println!("{}", displayable(stage.as_ref()).indent()); | |||
There was a problem hiding this comment.
| Rank, | ||
| DenseRank, | ||
| PercentRank, | ||
| Basic, |
There was a problem hiding this comment.
| return None | ||
| }; | ||
| // The result may be None, because DataFusion doesn't have support for ScalarValues of the column type | ||
| let null_scalar: ScalarValue = data_type.try_into().ok()?; |
There was a problem hiding this comment.
| @@ -1739,7 +1739,7 @@ impl fmt::Display for ScalarValue { | |||
| fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { | |||
| match self { | |||
| ScalarValue::Decimal128(v, p, s) => { | |||
| write!(f, "{}", format!("{:?},{:?},{:?}", v, p, s))?; | |||
| write!(f, "{:?},{:?},{:?}", v, p, s)?; | |||
There was a problem hiding this comment.
|
Thanks @xudong963 ! |
I wrote this PR without reading the email today, so I didn't notice that you have already filed a ticket. I'm sorry @alamb |
|
No worries at all 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
https://blog.rust-lang.org/2022/01/13/Rust-1.58.0.html
What changes are included in this PR?
Are there any user-facing changes?