Add covar, covar_pop and covar_samp aggregate functions
#1551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ballista
datafusion
realno
commented
Jan 12, 2022
| @@ -605,6 +605,62 @@ mod tests { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| #[test] | |||
There was a problem hiding this comment.
Added some test for variance to test merge rules.
realno
commented
Jan 12, 2022
| @@ -411,6 +411,62 @@ mod tests { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| #[test] | |||
There was a problem hiding this comment.
Added tests for merge rule.
|
Thank you for your works! @realno |
|
Thanks @realno @houqp and @liukun4515 -- I didn't review this code but I trust your reviews 👍 |
alamb
changed the title
covar, covar_pop and covar_samp aggregate functions
alamb
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1548 .
Rationale for this change
This PR adds
covar,covar_popandcovar_sampstatistical functions as aggregators to DataFusion.What changes are included in this PR?
Are there any user-facing changes?
The following operators are added:
covarcovar_popcovar_sampNo breaking changes.