support comparison for decimal data type and refactor the binary coercion rule #1483
Conversation
liukun4515
changed the title
liukun4515
force-pushed
the
comparsion_decimal_support
branch
from
1684d63 to
ed8ef8f
Compare
| @@ -501,58 +706,6 @@ macro_rules! compute_utf8_flag_op_scalar { | |||
| }}; | |||
| } | |||
|
|
|||
| /// Coercion rules for all binary operators. Returns the output type | |||
| /// of applying `op` to an argument of `lhs_type` and `rhs_type`. | |||
| fn common_binary_type( | |||
There was a problem hiding this comment.
move the main code to the file of binary_rule.rs.
|
I will review this tomorrow if no one else gets to it first. I ran out of time for today to review code |
We can merge the cast/try_cast pull request first. |
There was a problem hiding this comment.
I went through this pretty carefully -- nice work @liukun4515 . Thank you for the contribution
the only other thing I think would be helpful would be some end to end tests (e.g. in tests/sql) demonstrating doing operations (like adding a decimal to an int). However, I also think that would be fine to do as a follow on PR
tracked in the subtask #122 (comment) |
Which issue does this PR close?
part of #122
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?