Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use arrow 6.1.0 #1255

Merged
merged 1 commit into from
Nov 6, 2021
Merged

use arrow 6.1.0 #1255

merged 1 commit into from
Nov 6, 2021

Conversation

jimexist
Copy link
Member

@jimexist jimexist commented Nov 6, 2021

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added ballista datafusion Changes in the datafusion crate labels Nov 6, 2021
@houqp houqp merged commit e84a0bf into apache:master Nov 6, 2021
@houqp houqp added enhancement New feature or request python labels Nov 6, 2021
@jimexist jimexist deleted the use-arrow-61 branch November 8, 2021 06:01
@@ -29,7 +29,7 @@ publish = false
rust-version = "1.56"

[dependencies]
arrow-flight = { version = "6.0.0" }
arrow-flight = { version = "6.1.0" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these versions need to be something like ^6.1.0 to force using arrow 6.1.0 or newer

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dandandan mentioned that in my previous PR that by default cargo treats 6.1.0 as ^6.1.0: https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#specifying-dependencies-from-cratesio

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should use "6.1" instead of "6.1.0" to make it less restrictive.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, that's a good idea.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FTR, They are all functionally equivalent.
= and ^ both mean semver compatible. Adding the final zero has no effect (but might be more clear to remove it)

Source:
https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#specifying-dependencies-from-cratesio

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha, you are right. patch version only makes sense if we need it to be higher than a particular patch release, i.e. greater than 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datafusion Changes in the datafusion crate enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants