-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use arrow 6.1.0 #1255
use arrow 6.1.0 #1255
Conversation
afc7177
to
a094603
Compare
@@ -29,7 +29,7 @@ publish = false | |||
rust-version = "1.56" | |||
|
|||
[dependencies] | |||
arrow-flight = { version = "6.0.0" } | |||
arrow-flight = { version = "6.1.0" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these versions need to be something like ^6.1.0
to force using arrow 6.1.0 or newer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dandandan mentioned that in my previous PR that by default cargo treats 6.1.0
as ^6.1.0
: https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#specifying-dependencies-from-cratesio
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we should use "6.1" instead of "6.1.0" to make it less restrictive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, that's a good idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FTR, They are all functionally equivalent.
=
and ^
both mean semver compatible. Adding the final zero has no effect (but might be more clear to remove it)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ha, you are right. patch version only makes sense if we need it to be higher than a particular patch release, i.e. greater than 0.
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?