optimize build profile for datafusion python binding, cli and ballista #1137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houqp
added
ballista
datafusion
houqp
changed the title
houqp
changed the title
following our own optimization guideline: https://arrow.apache.org/datafusion/user-guide/library.html
alamb
reviewed
Oct 18, 2021
| @@ -29,3 +29,7 @@ members = [ | |||
| ] | |||
|
|
|||
| exclude = ["python"] | |||
|
|
|||
| [profile.release] | |||
There was a problem hiding this comment.
Would these settings end up applying to any crate that uses datafusion as a dependency? Or only when a project is built within the datafusion workspace?
There was a problem hiding this comment.
I believe profiles are workspace specific. downstream projects need to set their own release profile if they need to get the same performance boost.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Following our own optimization guideline: https://arrow.apache.org/datafusion/user-guide/library.html. Each one of these changes resulted in 10-20% performance boost for roapi, so I figured we should set the same default for datafusion and ballista binaries.
What changes are included in this PR?
Are there any user-facing changes?
no