Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[crypto] add blake3 algorithm to digest function #1086

Merged
merged 1 commit into from
Oct 12, 2021

Conversation

jimexist
Copy link
Member

@jimexist jimexist commented Oct 8, 2021

Which issue does this PR close?

Add blake3, following #1094

Closes #1101

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

yes the digest function now supports using blake3 as the second parameter

@github-actions github-actions bot added ballista datafusion Changes in the datafusion crate labels Oct 8, 2021
@houqp
Copy link
Member

houqp commented Oct 9, 2021

@jimexist looks like there are matching related build error needs to be resolved.

@jimexist jimexist force-pushed the add-blake3 branch 3 times, most recently from 2925be0 to 54285b5 Compare October 10, 2021 15:47
Copy link
Member

@houqp houqp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting that blake3's api is slightly different 🤔

@houqp houqp added the enhancement New feature or request label Oct 10, 2021
@jimexist
Copy link
Member Author

interesting that blake3's api is slightly different 🤔

yeah it's a bit weird

@jimexist jimexist requested a review from alamb October 11, 2021 03:32
@jimexist jimexist changed the title [crypto] Add blake3 [crypto] add blake3 algorithm to digest function Oct 11, 2021
@alamb alamb merged commit d2d47d3 into apache:master Oct 12, 2021
@alamb
Copy link
Contributor

alamb commented Oct 12, 2021

Thanks @jimexist

@jimexist jimexist deleted the add-blake3 branch October 12, 2021 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datafusion Changes in the datafusion crate enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement blake3 function
3 participants