Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register tables in BallistaContext using TableProviders instead of Dataframe #1028

Merged
merged 1 commit into from
Sep 20, 2021
Merged

Register tables in BallistaContext using TableProviders instead of Dataframe #1028

merged 1 commit into from
Sep 20, 2021

Conversation

rdettai
Copy link
Contributor

@rdettai rdettai commented Sep 20, 2021 •
edited
Loading

Which issue does this PR close?

Closes #1027 and Closes #1016.

What changes are included in this PR?

  • Removed the DfTableAdapter wrapper
  • removed dead code from scheduler planner (execution_plan could not be downcasted to DfTableAdapter)
  • unwrap the dataframe into a table provider directly in the register_xx methods

Are there any user-facing changes?

BallistaContext.register_table() takes TableProviders instead of DataFrames.

@rdettai rdettai mentioned this pull request Sep 20, 2021
Merged
Dandandan
Dandandan approved these changes Sep 20, 2021
View reviewed changes
Copy link
Contributor

@Dandandan Dandandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - this definitely makes sense and looks like it simplifies a lot.

houqp
houqp approved these changes Sep 20, 2021
View reviewed changes
Copy link
Member

@houqp houqp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change, also makes it consistent with what we have in datafusion context.

@houqp houqp added the api change Changes the API exposed to users of the crate label Sep 20, 2021
@houqp houqp changed the title Remove ability to register dataframes on BallistaContext Register tables in BallistaContext using TableProviders instead of Dataframe Sep 20, 2021
@houqp houqp merged commit 843cd93 into apache:master Sep 20, 2021
@rdettai rdettai deleted the register-dataframe branch September 21, 2021 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houqp houqp houqp approved these changes

@Dandandan Dandandan Dandandan approved these changes

Assignees
No one assigned
Labels
api change Changes the API exposed to users of the crate
Projects
None yet
Milestone
No milestone
3 participants
@rdettai @Dandandan @houqp