New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix an issue where aliases are not respected in generating downstream schemas in window expr #592

Closed

jimexist opened this issue Jun 20, 2021 · 1 comment · Fixed by #607

Member

jimexist commented Jun 20, 2021

looks like integration test is failing due to mismatch between logical schema and physical schema for window queries, i will dig into this.

thanks, it might be because of some edge cases that i did miss. i didn't find time to fix it but so far this query will fail:

> select max(c1) over () max_c1, max(c1) over (partition by c2) max_c1_by_c2 from test;
Plan("Schema contains duplicate unqualified field name 'MAX(c1)'")

Originally posted by @jimexist in #55 (comment)

jimexist mentioned this issue

Support qualified columns in queries #55

Merged

3 tasks

Member

houqp commented Jun 20, 2021

looks like the error only shows up when partition by c2 is provided in the second column.

jimexist mentioned this issue

fix 592, support alias in window functions #607

Merged

alamb closed this as completed in #607

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment