Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use a more rust idiomatic way of handling nth_value #448

Closed
jimexist opened this issue May 30, 2021 · 0 comments · Fixed by #452
Closed

use a more rust idiomatic way of handling nth_value #448

jimexist opened this issue May 30, 2021 · 0 comments · Fixed by #452

Comments

@jimexist
Copy link
Member

I wonder if a more idomatic Rust way of doing this would be an enum like

enum NthValue {
  First,
  Last,
  Nth(u32)
}

And then in NthValueAccumulator::scan you would have something like

match self.n {
  NthValue::First|NthValue::Nth(1)  => {...}
  Nth::Last => {..}
}

There is nothing wrong with the special value approach either -- I just figured I would point it out

Originally posted by @alamb in #403 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant