Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicated fn aggregate() in aggregate expression tests #2399

Closed
WinkerDu opened this issue May 1, 2022 · 0 comments · Fixed by #2400
Closed

remove duplicated fn aggregate() in aggregate expression tests #2399

WinkerDu opened this issue May 1, 2022 · 0 comments · Fixed by #2400

Comments

@WinkerDu
Copy link
Contributor

WinkerDu commented May 1, 2022

Here are duplicated fn aggregate() implementations in multiple aggregate expressions like sum.rs, average.rs, correlation.rs, etc.
We can remove them and use crate::expressions::tests::aggregate instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant