Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement extensible configuration mechanism #138

Closed
alamb opened this issue Apr 26, 2021 · 2 comments · Fixed by #2754
Closed

Implement extensible configuration mechanism #138

alamb opened this issue Apr 26, 2021 · 2 comments · Fixed by #2754
Assignees
Labels
datafusion Changes in the datafusion crate

Comments

@alamb
Copy link
Contributor

alamb commented Apr 26, 2021

Note: migrated from original JIRA: https://issues.apache.org/jira/browse/ARROW-11059

We are getting to the point where there are multiple settings we could add to operators to fine-tune performance. Custom operators provided by crates that extend DataFusion may also need this capability.

I propose that we add support for key-value configuration options so that we don't need to plumb through each new configuration setting that we add.

For example. I am about to start on a "coalesce batches" operator and I would like a setting such as "coalesce.batch.size".

For built-in settings like this we can provide information such as documentation and default values and generate documentation from this.

For example, here is how Spark defines configs:
{code:java}
val PARQUET_VECTORIZED_READER_ENABLED =
buildConf("spark.sql.parquet.enableVectorizedReader")
.doc("Enables vectorized parquet decoding.")
.version("2.0.0")
.booleanConf
.createWithDefault(true) {code}

@andygrove
Copy link
Member

I plan on working on this very soon

@alamb
Copy link
Contributor Author

alamb commented Jun 21, 2022

cc @ming535

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datafusion Changes in the datafusion crate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants