-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why use the expr types before coercion to get the result type? #1358
Comments
if the question is "should we use the argument types after coercion" that seems to make sense to me, but I haven't thought about it all that much |
This an invalid issue, this line is my intention. |
@liukun4515 are you suggesting we close this issue? |
Yes, i will close it. |
https://github.com/apache/arrow-datafusion/blob/15db29153aefc9b759ec03e6eeab8cb9ebf87781/datafusion/src/physical_plan/functions.rs#L1144
In order to get agg phy expr, we need to coerce the input exprs(may need to add try_cast to wrap the expr), so the types of
coerced exprs is diff with the types of input exprs.
In the below code, we also need to use the coerced exprs and coerced types to generate the agg expr.
The text was updated successfully, but these errors were encountered: