Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First pass of documentation in mdBook #364

Merged
merged 3 commits into from
May 4, 2023
Merged

Conversation

MrPowers
Copy link
Contributor

@MrPowers MrPowers commented May 1, 2023

Which issue does this PR close?

Closes #339.

Rationale for this change

The documentation is currently in sphinx, which is challenging to update (requires RST, not markdown) and has bad default settings for SEO/usability. Migrating the documentation to mdBook will make it easier to build an amazing user guide.

What changes are included in this PR?

A folder that generates a mdBook documentation site.

Are there any user-facing changes?

No, this just changed the documentation. No code changes.

@MrPowers
Copy link
Contributor Author

MrPowers commented May 1, 2023

Screenshot 2023-05-01 at 9 34 17 AM

mdBook generates docs that are really nice-looking. Excited to collaborate on the team with next steps!

@@ -0,0 +1,6 @@
[book]
authors = ["Matthew Powers"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change this to something like this:

authors = ["Apache Arrow <[email protected]>"]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.


## Examples

See the [pydata-examples](https://github.com/MrPowers/pydata-examples) for a variety of Jupyter notebooks that show DataFusion in action!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we link to an example in this repo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed this to the examples in this repo, which feels more appropriate.


It's easy to create DataFusion tables from a variety of data sources.

## Create table from Python Dictionary
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to capitalize "table" here and the following sections?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, updated throughout.

@@ -0,0 +1,17 @@
# DataFusion Book
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to add ASF headers to all of these .md files:

Suggested change
# DataFusion Book
<!---
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
# DataFusion Book

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the license throughout.

@andygrove
Copy link
Member

Thanks @MrPowers this looks like a great start. I left some feedback.

@MrPowers
Copy link
Contributor Author

MrPowers commented May 3, 2023

Thanks for the review @andygrove. Feel free to comment with any other next steps and I'll be happy to continue updating this PR.

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andygrove
Copy link
Member

@MrPowers two more files need ASF headers:

NOT APPROVED: docs/mdbook/README.md (./docs/mdbook/README.md): false
NOT APPROVED: docs/mdbook/book.toml (./docs/mdbook/book.toml): false

@MrPowers
Copy link
Contributor Author

MrPowers commented May 4, 2023

Thanks @andygrove, made those updates.

@andygrove andygrove merged commit 4175134 into apache:main May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert documentation to mdbooks
2 participants