Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Mac/Win release builds in CI #313

Merged
merged 7 commits into from
Apr 4, 2023
Merged

Fix Mac/Win release builds in CI #313

merged 7 commits into from
Apr 4, 2023

Conversation

andygrove
Copy link
Member

@andygrove andygrove commented Apr 3, 2023 •
edited
Loading

Which issue does this PR close?

Closes #211

Rationale for this change

What changes are included in this PR?

  • Install protoc for non-containerized builds (mac/win)
  • Speficy protoc feature for containerized builds (linux/source)

Are there any user-facing changes?

@andygrove andygrove changed the title remove aminya/setup-cpp@v1 Try and fix Mac/Win release builds in CI Apr 3, 2023
@andygrove andygrove marked this pull request as ready for review April 4, 2023 14:22
@andygrove andygrove changed the title Try and fix Mac/Win release builds in CI Fix Mac/Win release builds in CI Apr 4, 2023
@andygrove andygrove merged commit 47dd8e5 into apache:main Apr 4, 2023
@andygrove andygrove deleted the try-fix-ci-2 branch April 4, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release workflow is failing
1 participant
@andygrove