Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python wrappers for LogicalPlan::Join and LogicalPlan::CrossJoin #246

Merged
merged 2 commits into from
Mar 1, 2023

Conversation

iajoiner
Copy link
Contributor

Which issue does this PR close?

Part of #191.

Rationale for this change

What changes are included in this PR?

Add Join, CrossJoin, JoinType and JoinConstraint.

Are there any user-facing changes?

@iajoiner
Copy link
Contributor Author

iajoiner commented Feb 27, 2023

@andygrove I'm half way done with repartition as well though I do wonder how we are supposed to wrap logical_plan::Partitioning. Everything else in your Operator list should at least have a PR now.

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andygrove
Copy link
Member

@iajoiner There are some conflicts on this PR now

@iajoiner
Copy link
Contributor Author

@andygrove Working on it now.

@iajoiner
Copy link
Contributor Author

@andygrove Fixed!

@andygrove andygrove merged commit 6cd74a9 into apache:main Mar 1, 2023
@iajoiner iajoiner deleted the join branch March 1, 2023 14:15
@andygrove andygrove added the enhancement New feature or request label Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants