refactor: port get_scan_files to Ballista #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Sep 8, 2023
| @@ -39,7 +39,6 @@ use ballista_core::serde::protobuf::{ | |||
| use ballista_core::serde::scheduler::{ExecutorData, ExecutorMetadata}; | |||
| use ballista_core::serde::BallistaCodec; | |||
| use dashmap::DashMap; | |||
| use datafusion::datasource::physical_plan::get_scan_files; | |||
There was a problem hiding this comment.
The point of this PR is to remove this dependency (so we can remove it from DataFusion)
Dandandan
approved these changes
Sep 15, 2023
|
Thanks @Dandandan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to apache/datafusion#7357
Rationale for this change
We are sorting out how to split up DataFusion into smaller modules, and we hit apache/datafusion#7357
There is a tension between knowing about datasources and separating out physical plan and datasources (see commentary on apache/datafusion#7357 and linked PRs).
We thus propose to move this API upstream into Ballista. See apache/datafusion#7487
What changes are included in this PR?
Are there any user-facing changes?
No