Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config to collect statistics, enable in TPC-H benchmark #796

Merged
merged 10 commits into from
May 30, 2023

Conversation

Dandandan
Copy link
Contributor

@Dandandan Dandandan commented May 30, 2023

Which issue does this PR close?

Closes #797

Allows configuring the CollectLeft threshold in Ballista and enable collecting statistics in TPC-H benchmark.

(2,5,7,8,9,10,11,14,15,16,21 are faster with statistics available because of better join selection)

without collecting stats with collecting stats
1 1450.91 1451.59
2 1462.58 846.69
3 1146.47 1142.10
4 935.40 936.54
5 1767.56 1357.01
6 516.96 518.90
7 2114.79 1667.12
8 2503.08 1707.93
9 2175.66 1734.37
10 1403.69 1158.69
11 1115.91 765.67
12 1080.43 1080.57
13 1244.99 1243.37
14 938.96 519.41
15 1683.18 1511.17
16 1336.33 1151.75
17 1963.21 1963.03
18 2001.95 2002.84
19 1294.52 1259.65
20 1250.44 1248.19
21 1771.44 1555.07

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot removed the python label May 30, 2023
@Dandandan Dandandan changed the title Add config to collect statistics Add config to collect statistics, enable in TPC-H benchmark May 30, 2023
Copy link
Contributor

@r4ntix r4ntix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dandandan Dandandan merged commit 0d3a511 into main May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow configuring statistics collection during scan
2 participants