Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine the ExecuteQuery grpc interface #790

Merged
merged 2 commits into from
May 30, 2023
Merged

Refine the ExecuteQuery grpc interface #790

merged 2 commits into from
May 30, 2023

Conversation

yahoNanJing
Copy link
Contributor

@yahoNanJing yahoNanJing commented May 29, 2023 •
edited
Loading

Which issue does this PR close?

Closes #789.

Rationale for this change

What changes are included in this PR?

  • Decouple session related operations from the execute_query interface
  • Three session related grpc interface are added
  • Failure details are added to the execute_query grpc interface

Are there any user-facing changes?

@yahoNanJing
Copy link
Contributor Author

Hi @thinkharderdev, @andygrove, could you help review this PR?

@yahoNanJing yahoNanJing changed the title Issue 789 Refine the ExecuteQuery grpc interface May 29, 2023
@yahoNanJing yahoNanJing merged commit 01bcf7c into apache:main May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkharderdev thinkharderdev thinkharderdev approved these changes

@avantgardnerio avantgardnerio Awaiting requested review from avantgardnerio

@andygrove andygrove Awaiting requested review from andygrove

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refine the ExecuteQuery grpc interface
3 participants
@yahoNanJing @thinkharderdev @kyotoYaho