Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make last_seen_ts_threshold for getting alive executor at the scheduler side larger than the heartbeat time interval #786

Merged
merged 1 commit into from
May 30, 2023
Merged

Make last_seen_ts_threshold for getting alive executor at the scheduler side larger than the heartbeat time interval #786

merged 1 commit into from
May 30, 2023

Conversation

yahoNanJing
Copy link
Contributor

@yahoNanJing yahoNanJing commented May 29, 2023 •
edited
Loading

Which issue does this PR close?

Closes #785.

Rationale for this change

What changes are included in this PR?

  • Make hard coded settings configurable, like DEFAULT_EXECUTOR_TIMEOUT_SECONDS, EXPIRE_DEAD_EXECUTOR_INTERVAL_SECS.
  • Make several structs for scheduler have the SchedulerConfig property and remove detailed settings, like ExecutorManager, QueryStageScheduler, etc.
  • Use the executor_timeout_seconds for alive executor detection. It's larger than the executor_heartbeat_interval_seconds.

Are there any user-facing changes?

@kyotoYaho
Make last_seen_ts_threshold for getting alive executor at the schedul…
9a911f9 
…er side larger than the heartbeat time interval
@yahoNanJing
Copy link
Contributor Author

Hi @thinkharderdev and @andygrove, could you help review this PR?

@yahoNanJing yahoNanJing merged commit 2f0f27c into apache:main May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkharderdev thinkharderdev thinkharderdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@yahoNanJing @thinkharderdev @kyotoYaho