[fea] Avoid multithreaded write lock conflicts in event queue. #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ted-Jiang
commented
Apr 25, 2023
| queued_at, | ||
| submitted_at: timestamp_millis(), | ||
| resubmit: false, | ||
| plan, |
There was a problem hiding this comment.
move the job related status updating to QueryStageSchedulerEvent::JobSubmitted
|
I will merge this one, If anyone have problem i will be happy to fix it. |
Ted-Jiang
force-pushed
the
avoid_empty_event
branch
from
bce2959
to
4111a93
Compare
Ted-Jiang
force-pushed
the
avoid_empty_event
branch
from
4111a93
to
abab728
Compare
Ted-Jiang
force-pushed
the
avoid_empty_event
branch
from
abab728
to
a21036a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #753.
Rationale for this change
After fix concurrency visit lock before four long running event reduce to 200~500 micro seconds cost.
What changes are included in this PR?
Are there any user-facing changes?