Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[log] Print long running task status. #750

Merged
merged 1 commit into from
Apr 23, 2023
Merged

Conversation

Ted-Jiang
Copy link
Member

Which issue does this PR close?

Closes #749.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

Copy link
Contributor

@avantgardnerio avantgardnerio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I've found metrics endpoints like the Prometheus one we have in the scheduler to generally be a more robust solution to this problem as I understand it. Would that be an alternative solution for the case you are trying to cover?

@Ted-Jiang
Copy link
Member Author

Ted-Jiang commented Apr 23, 2023

| Would that be an alternative solution for the case you are trying to cover?

@avantgardnerio Thanks for remind me this. Yes, For user like us, us ES to collect metrics, directly print it out is enough. btw this feature is default off.

Copy link
Contributor

@yahoNanJing yahoNanJing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ted-Jiang Ted-Jiang merged commit 805e346 into apache:main Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[LOG] Print long running task status.
4 participants