Only decode plan in LaunchMultiTaskParams once
#743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dandandan
changed the title
LaunchMultiTaskParams once
yahoNanJing
pushed a commit
to yahoNanJing/arrow-ballista
that referenced
this pull request
Jun 26, 2023
This reverts commit 4e4842c.
yahoNanJing
added a commit
that referenced
this pull request
Jun 28, 2023
…e decoded one (#817) * Revert "Only decode plan in `LaunchMultiTaskParams` once (#743)" This reverts commit 4e4842c. * Refactor the TaskDefinition by changing encoding execution plan to the decoded one * Refine the error handling of run_task in the executor_server --------- Co-authored-by: yangzhong <[email protected]>
yahoNanJing
pushed a commit
to yahoNanJing/arrow-ballista
that referenced
this pull request
Jun 28, 2023
This reverts commit 4e4842c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #742
Rationale for this change
When starting many tasks on single executors, the execution plan is decoded for every task/partition.
This can take quite a bit of time for larger plans, delaying execution and consumes quite some memory as well for executors that start a lot of tasks for the same query stage at the same time.
What changes are included in this PR?
Decode the plan only once and share the
Arc<dyn ExecutionPlan>.Are there any user-facing changes?