Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nodejs issues in Docker build #731

Merged
merged 1 commit into from
May 29, 2023
Merged

Fix nodejs issues in Docker build #731

merged 1 commit into from
May 29, 2023

Conversation

jnaous
Copy link
Contributor

@jnaous jnaous commented Mar 31, 2023

Closes #717

Fixes the issue by installing the right version of nodejs.

@jnaous jnaous mentioned this pull request Mar 31, 2023
Closed
@paolorechia
Copy link
Contributor

LGTM - I didn't test this though :)

r4ntix
r4ntix approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@r4ntix r4ntix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kylebrooks-8451
Copy link

kylebrooks-8451 commented May 28, 2023 •
edited
Loading

@r4ntix Can we merge this? I was hoping to get the docker build to run again.

@jnaous
Copy link
Contributor Author

jnaous commented May 28, 2023

Waiting for a committer... perhaps @andygrove?

@r4ntix
Copy link
Contributor

r4ntix commented May 28, 2023

@r4ntix Can we merge this? I was hoping to get the docker build to run again.

Sorry, I don't have permission to merge the PR.

@andygrove @yahoNanJing @Ted-Jiang Could you help review it?

@avantgardnerio avantgardnerio merged commit b70b372 into apache:main May 29, 2023
@avantgardnerio
Copy link
Contributor

It looks like it did fix it, and the checks passed in the branch, but it failed when merged to main:

yarn install v1.22.19
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
warning " > @chakra-ui/[email protected]" has unmet peer dependency "@chakra-ui/system@>=1.0.0".
warning "@chakra-ui/icons > @chakra-ui/[email protected]" has unmet peer dependency "@chakra-ui/system@>=1.0.0".
warning " > @testing-library/[email protected]" has unmet peer dependency "@testing-library/dom@>=7.21.4".
[4/4] Building fresh packages...
Done in 37.20s.
yarn run v1.22.1[9](https://github.com/apache/arrow-ballista/actions/runs/5113530837/jobs/9192844132#step:5:10)
$ react-scripts --openssl-legacy-provider build
/usr/bin/node: bad option: --openssl-legacy-provider
error Command failed with exit code 9.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Error: Process completed with exit code 9.

Does anyone know why that error might be happening there?

@paolorechia
Copy link
Contributor

Hi, @avantgardnerio, my first hunch is that the installed node version does not match what we expect (18)

If I’m not mistaken, this OpenSSL flag is added to node 17+

When peeking at the build logs, I saw this (nodejs v12):

https://github.com/apache/arrow-ballista/actions/runs/5113530837/jobs/9192844132#step:4:1079

I hope I read it correctly, hard to search the logs in my mobile phone :)

@avantgardnerio
Copy link
Contributor

Hi all, PTAL at #794 since this seems like it will fix the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paolorechia paolorechia paolorechia approved these changes

@avantgardnerio avantgardnerio avantgardnerio approved these changes

@r4ntix r4ntix r4ntix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Building Docker images on main branch fails
5 participants
@jnaous @paolorechia @kylebrooks-8451 @r4ntix @avantgardnerio